Skip to content

test: fix embedtest not running code #49502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mmomtchev wants to merge 3 commits into from
Closed

test: fix embedtest not running code #49502

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d736ce3
test: fix embedtest not running code
mmomtchev Sep 5, 2023
1690779
add a test for the test
mmomtchev Sep 5, 2023
9eb6317
fix what appears to be a typo
mmomtchev Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add a test for the test
  • Loading branch information
@mmomtchev
mmomtchev committed Sep 5, 2023
commit 1690779b0343a4f4f2e6aa426ff6e64609f170d3
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ coverage-report-js:
cctest: all
@out/$(BUILDTYPE)/$@ --gtest_filter=$(GTEST_FILTER)
@out/$(BUILDTYPE)/embedtest "require('./test/embedding/test-embedding.js')"
@out/$(BUILDTYPE)/embedtest "throw new Error" > /dev/null 2>&1; test "$?" -eq 1

.PHONY: list-gtests
list-gtests:
Expand Down