test: Add assertion for TLS peer certificate fingerprint#4923
test: Add assertion for TLS peer certificate fingerprint#4923alandotcom wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
tls
|
LGTM but can you amend the commit log so it conforms to the guidelines from CONTRIBUTING.md? In particular, it should start with the subsystem ( CI: https://ci.nodejs.org/job/node-test-pull-request/1419/ (currently private because of the upcoming security release.) |
alandotcom
force-pushed
the
test-fingerprint
branch
from
8734d1b to
48afa53
Compare
alandotcom
changed the title
|
Thanks @bnoordhuis. Just updated the commit message |
|
LGTM |
|
@LumberJ Can you run |
PR-URL: nodejs#4923 Reviewed-By: Ben Noordhuis <[email protected]>
alandotcom
force-pushed
the
test-fingerprint
branch
from
48afa53 to
7b61f02
Compare
|
Thanks, just fixed the lint error. On Fri, Jan 29, 2016 at 12:36 AM, Ben Noordhuis [email protected]
Alan Cohen |
PR-URL: #4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 59fb26c |
PR-URL: #4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: nodejs#4923 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
5 participants
PR-URL: #4923
Reviewed-By: Ben Noordhuis [email protected]