Skip to content

tls: fix bugs of double TLS #48969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ywave620 wants to merge 6 commits into from
Closed

tls: fix bugs of double TLS #48969

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
63c8fb0
tls: fix bugs of double TLS
ywave620 Jul 15, 2023
7e2ec19
tls: fix bugs of double TLS
ywave620 Jul 16, 2023
8ce31c6
tls: fix bugs of double TLS
ywave620 Jul 17, 2023
29aade9
tls: fix bugs of double TLS
ywave620 Jul 17, 2023
363c80a
tls: fix bugs of double TLS
ywave620 Jul 30, 2023
a6f8445
tls: fix bugs of double TLS
ywave620 Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tls: fix bugs of double TLS 
Remove unnecessary saving of `this` for arrow function.
  • Loading branch information
@ywave620
ywave620 committed Jul 17, 2023
commit 8ce31c603ef7bb68ed3c12d99e84bdfeaa7bb07e
5 changes: 2 additions & 3 deletions lib/_tls_wrap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,15 +597,14 @@ function TLSSocket(socket, opts) {
// `wrap` is a streams.Writable in JS. This empty write will be queued
// and hence finish after all existing writes, which is the timing
// we want to start to send any tls data to `wrap`.
const that = this;
wrap.write('', (err) => {
if (err) {
debug('error got before writing any tls data to the underlying stream');
that.destroy(err);
this.destroy(err);
return;
}

that._handle.writesIssuedByPrevListenerDone();
this._handle.writesIssuedByPrevListenerDone();
});
}

Expand Down