tools: fix type sniffing for properties in JSON generation#4884
Closed
TimothyGu wants to merge 1 commit intonodejs:masterfrom
TimothyGu:type-in-props
Closed
tools: fix type sniffing for properties in JSON generation#4884TimothyGu wants to merge 1 commit intonodejs:masterfrom TimothyGu:type-in-props
TimothyGu wants to merge 1 commit intonodejs:masterfrom
TimothyGu:type-in-props
Conversation
mscdex
added
doc
Contributor
|
LGTM with a couple of nits: the commit should target |
Member
Author
|
@mscdex, done. |
Member
|
LGTM |
mscdex
changed the title
Member
Author
|
Ping. |
Member
|
I don't think running CI does anything with |
Member
|
Not sure what's up with the ARM hosts in CI right now (stuck in pending, won't start a CI run) but everything else is green. This probably isn't even anything anyone will ever run on ARM anyway since it's internal tooling. And CI doesn't even exercise this code, so the CI run is kind of a symbolic gesture more than anything else. So, will land in another minute or two... |
Member
|
|
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 30, 2016
PR-URL: nodejs#4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Member
|
Landed in ab45390 |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
PR-URL: #4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
PR-URL: #4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
PR-URL: #4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4884 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Brian White <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
{ "textRaw": "`children` {Array} ", "name": "children", "desc": "<p>The module objects required by this one.\n\n</p>\n" },(https://nodejs.org/api/modules.json)
After:
{ "textRaw": "`children` {Array} ", "type": "Array", "name": "children", "desc": "<p>The module objects required by this one.\n\n</p>\n" },