Skip to content

fs, stream: add initial Symbol.dispose and Symbol.asyncDispose support #48518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Jun 25, 2023
Merged

fs, stream: add initial Symbol.dispose and Symbol.asyncDispose support #48518

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a25397
fs, stream: initial `Symbol.dispose` and `Symbol.asyncDispose` support
MoLow Jun 22, 2023
8dc2ee7
Update lib/internal/process/pre_execution.js
MoLow Jun 22, 2023
223a2d8
Update lib/internal/streams/readable.js
MoLow Jun 22, 2023
40ba972
lint
MoLow Jun 22, 2023
e8a014f
Update lib/internal/streams/readable.js
benjamingr Jun 22, 2023
48602bb
Update lib/internal/streams/readable.js
benjamingr Jun 22, 2023
39b6ace
eslint disable
MoLow Jun 22, 2023
a6d798d
CR
MoLow Jun 22, 2023
98285ae
docs: add experimental
MoLow Jun 23, 2023
5d0d435
Update doc/api/stream.md
benjamingr Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
  • Loading branch information
@MoLow
MoLow committed Jun 22, 2023
commit 40ba972930943350b51da59c2dc2f6789efe435b
2 changes: 1 addition & 1 deletion lib/internal/streams/readable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ Readable.prototype[EE.captureRejectionSymbol] = function(err) {
};

Readable.prototype[SymbolAsyncDispose] = function() {
let error
let error;
if (!this.destroyed) {
error = new AbortError();
this.destroy(error);
Expand Down