doc: Examples work when data exceeds buffer size#4811
Closed
garrows wants to merge 1 commit intonodejs:masterfrom
Closed
doc: Examples work when data exceeds buffer size#4811garrows wants to merge 1 commit intonodejs:masterfrom
garrows wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
crypto
Member
|
@nodejs/crypto |
Member
|
LGTM but the commit log should conform to the guidelines. Can you update it according to CONTRIBUTING.md? |
Contributor
|
I think it is a kind of topics how to write a stream example in a doc rather than crypto feature. |
Contributor
|
From a |
Contributor
|
@eljefedelrodeodeljefe Okay, thanks. LGTM too. |
garrows
force-pushed
the
fix/crypto-clarity
branch
from
2cbcc10 to
b4a0f20
Compare
garrows
changed the title
Contributor
Author
|
I've updated the commit message. Cheers. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Jan 23, 2016
PR-URL: #4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 26073dd |
Contributor
Author
|
Thanks for accepting! |
rvagg
pushed a commit
that referenced
this pull request
Jan 25, 2016
PR-URL: #4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
@jasnell added the lts-watch-v4.x label so this should get back-ported. |
Contributor
|
this commit relies on a number of other doc changes to land in LTS first. |
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
PR-URL: #4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
PR-URL: #4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
PR-URL: nodejs#4811 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Shigeki Ohtsu <[email protected]> Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crypto examples would only work when the input data was under 16 bytes. Above that, important data was being thrown away and decrypting them would give a difficult to debug error (see below).
Error given when
.updatedata was being discarded:Error: error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt