crypto: fix webcrypto private/secret import with empty usages#47877
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom May 7, 2023
Merged
crypto: fix webcrypto private/secret import with empty usages#47877nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
crypto
Member
Author
|
How do we deal with the semverness of this? The keys were unusable before, they are non-importable now. It is unlikely any code depended on import of keys that weren't usable for any operation but I'm keen to get more opinions. |
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Member
Author
Furthermore if any interoperable code uses webcrypto (kinda its whole point) it already can't depend on this as other implementations properly reject. I'm proposing to ship this is as a fix not as a breaking change. |
Member
|
I'd expect near-zero breakage, so spec-compliance outweighs that concern. |
Member
Author
|
In that case this is ready for reviews. |
tniessen
approved these changes
May 6, 2023
| } | ||
|
|
||
| throw lazyDOMException('Unrecognized algorithm name', 'NotSupportedError'); | ||
| if ((result.type === 'secret' || result.type === 'private') && result.usages.length === 0) { |
Member
There was a problem hiding this comment.
Suggested change
| if ((result.type === 'secret' || result.type === 'private') && result.usages.length === 0) { | |
| if (result.type !== 'public' && result.usages.length === 0) { |
panva
added
the
author ready
jasnell
approved these changes
May 6, 2023
panva
added
the
commit-queue
debadree25
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 71eda57 |
targos
pushed a commit
that referenced
this pull request
May 12, 2023
Refs: #47864 PR-URL: #47877 Refs: #47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
panva
added a commit
to panva/node
that referenced
this pull request
May 15, 2023
Refs: nodejs#47864 PR-URL: nodejs#47877 Refs: nodejs#47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Backport-PR-URL: nodejs#47336
danielleadams
pushed a commit
that referenced
this pull request
Jul 6, 2023
Refs: #47864 PR-URL: #47877 Refs: #47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
MoLow
pushed a commit
to MoLow/node
that referenced
this pull request
Jul 6, 2023
Refs: nodejs#47864 PR-URL: nodejs#47877 Refs: nodejs#47864 Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
privateandsecrettype keys are not allowed to have empty usagesRefs: #47864
cc @tniessen @fhanau