Skip to content

worker: add support for worker name in inspector and trace_events #46832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 20 commits into from
Mar 6, 2023
Merged

worker: add support for worker name in inspector and trace_events #46832

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
c977783
worker: add support for worker name in inspector and trace_events
debadree25 Feb 25, 2023
35811f5
fixup! remove breaking change
debadree25 Feb 26, 2023
2680a3e
fixup! add a test
debadree25 Feb 26, 2023
b6738e1
fixup! add doc
debadree25 Feb 26, 2023
1521950
fixup! lint
debadree25 Feb 26, 2023
2b4f742
fixup! lint
debadree25 Feb 26, 2023
38be52f
fixup! null check
debadree25 Feb 26, 2023
53e7098
fixup! simplify function
debadree25 Feb 26, 2023
54286bd
fixup! update name formation
debadree25 Feb 27, 2023
2e9c50b
fixup! refactor option name
debadree25 Feb 28, 2023
7d7c4e8
fixup! update worker trace name
debadree25 Feb 28, 2023
402bc6c
fixup! lint
debadree25 Feb 28, 2023
1bd70c2
fixup! lint
debadree25 Feb 28, 2023
28f812e
fixup! lint again
debadree25 Feb 28, 2023
1dd3e70
fixup! surround with mustcall
debadree25 Mar 1, 2023
239c849
fixup!
debadree25 Mar 1, 2023
21f8114
fixup! move the session to worker thread
debadree25 Mar 1, 2023
e75082d
fixup! keep worker alive
debadree25 Mar 2, 2023
48d97d6
fixup! move worker code to a fixture
debadree25 Mar 2, 2023
f5090a8
fixup! typo
debadree25 Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! add a test
  • Loading branch information
@debadree25
debadree25 committed Feb 28, 2023
commit 2680a3e09e4808cf6af0cbae9ecedbd982b2029f
25 changes: 25 additions & 0 deletions test/parallel/test-worker-title-prefix.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
'use strict';

const common = require('../common');
common.skipIfInspectorDisabled();
const assert = require('assert');
const { Worker, isMainThread } = require('worker_threads');

const { Session } = require('inspector');

if (isMainThread) {
const titlePrefix = 'Hello Thread ';
new Worker(__filename, {
workerData: 'Test Worker',
titlePrefix,
});

const session = new Session();
session.connect();
session.on('NodeWorker.attachedToWorker', ({ params: { workerInfo } }) => {
const id = workerInfo.id;
const expectedTitle = `${titlePrefix}Worker ${id}`;
Copy link
Member

@jasnell jasnell Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello ThreadWorker just feels a bit odd (specifically, not having a space between the prefix and Worker). I would almost prefer a model like Worker {id} [label] ... e.g. Worker 1 [Hello Thread]. Consider this non-blocking tho.

Copy link
Member Author

@debadree25 debadree25 Feb 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes i am updating the name formation as per this #46832 (comment)

assert.strictEqual(workerInfo.title, expectedTitle);
});
session.post('NodeWorker.enable', { waitForDebuggerOnStart: false });
}