Skip to content

encoding: use AliasedUint32Array for encodeInto results #46658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 5 commits into from
Closed

encoding: use AliasedUint32Array for encodeInto results #46658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
29ef3b0
benchmark: stablize encode benchmark
joyeecheung Feb 11, 2023
57bb217
src: move encoding bindings to a new binding
joyeecheung Feb 11, 2023
9b54d80
encoding: use AliasedUint32Array for encodeInto results
joyeecheung Feb 11, 2023
1233e7f
fixup! encoding: use AliasedUint32Array for encodeInto results
joyeecheung Mar 7, 2023
4ea7f2e
fixup! src: move encoding bindings to a new binding
joyeecheung Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: move encoding bindings to a new binding
  • Loading branch information
@joyeecheung
joyeecheung committed Mar 7, 2023
commit 4ea7f2e2cdbcf30a18b51c4f31dd2e5c4a4eb54e
2 changes: 0 additions & 2 deletions src/encoding_binding.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,12 @@ namespace encoding_binding {
using v8::ArrayBuffer;
using v8::BackingStore;
using v8::Context;
using v8::Function;
using v8::FunctionCallbackInfo;
using v8::Isolate;
using v8::Local;
using v8::MaybeLocal;
using v8::Object;
using v8::String;
using v8::Uint32Array;
using v8::Uint8Array;
using v8::Value;

Expand Down
2 changes: 1 addition & 1 deletion src/encoding_binding.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,4 +47,4 @@ class BindingData : public SnapshotableObject {

#endif // defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS

#endif // SRC_ENCODING_BINDING_H_
#endif // SRC_ENCODING_BINDING_H_