Skip to content

test_runner: make built in reporters internal #46092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jan 6, 2023
Merged

test_runner: make built in reporters internal #46092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test_runner: make built in reporters internal 
This commit updates the test runner to make the built in test
reporters internal modules.
  • Loading branch information
@cjihrig
cjihrig committed Jan 4, 2023
commit c1a4ccb58200ad52190236f7dbf44969a98e5a8d
0 lib/test/reporter/dot.js → lib/internal/test_runner/reporter/dot.js
View file
Open in desktop
File renamed without changes.
0 lib/test/reporter/spec.js → lib/internal/test_runner/reporter/spec.js
View file
Open in desktop
File renamed without changes.
0 lib/test/reporter/tap.js → lib/internal/test_runner/reporter/tap.js
View file
Open in desktop
File renamed without changes.
37 changes: 26 additions & 11 deletions lib/internal/test_runner/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,28 +93,43 @@ const kBuiltinDestinations = new SafeMap([
]);

const kBuiltinReporters = new SafeMap([
['spec', 'node:test/reporter/spec'],
['dot', 'node:test/reporter/dot'],
['tap', 'node:test/reporter/tap'],
['spec', 'internal/test_runner/reporter/spec'],
['dot', 'internal/test_runner/reporter/dot'],
['tap', 'internal/test_runner/reporter/tap'],
]);

const kDefaultReporter = 'tap';
const kDefaultDestination = 'stdout';

function tryBuiltinReporter(name) {
const builtinPath = kBuiltinReporters.get(name);

if (builtinPath === undefined) {
return;
}

return require(builtinPath);
}

async function getReportersMap(reporters, destinations) {
return SafePromiseAllReturnArrayLike(reporters, async (name, i) => {
const destination = kBuiltinDestinations.get(destinations[i]) ?? createWriteStream(destinations[i]);

// Load the test reporter passed to --test-reporter
const reporterSpecifier = kBuiltinReporters.get(name) ?? name;
let parentURL;
try {
parentURL = pathToFileURL(process.cwd() + '/').href;
} catch {
parentURL = 'file:///';
let reporter = tryBuiltinReporter(name);

if (reporter === undefined) {
let parentURL;

try {
parentURL = pathToFileURL(process.cwd() + '/').href;
} catch {
parentURL = 'file:///';
}

const { esmLoader } = require('internal/process/esm_loader');
reporter = await esmLoader.import(name, parentURL, ObjectCreate(null));
}
const { esmLoader } = require('internal/process/esm_loader');
let reporter = await esmLoader.import(reporterSpecifier, parentURL, ObjectCreate(null));

if (reporter?.default) {
reporter = reporter.default;
Expand Down