Skip to content

doc,lib: disambiguate the old term, NativeModule #45673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
daeyeon wants to merge 3 commits into from
Closed

doc,lib: disambiguate the old term, NativeModule #45673

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb4d44f
doc: disambiguate `native module` to `addon`
daeyeon Nov 29, 2022
f4d413e
lib: disambiguate `native module` to `builtin module`
daeyeon Nov 29, 2022
7d0872e
lib: disambiguate `native module` to `binding`
daeyeon Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lib: disambiguate native module to binding 
Signed-off-by: Daeyeon Jeong <[email protected]>
  • Loading branch information
@daeyeon
daeyeon committed Nov 30, 2022
commit 7d0872ead91b024620cb65905aba69bafb209e34
6 changes: 3 additions & 3 deletions lib/internal/bootstrap/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,9 @@ process.domain = null;
process._exiting = false;

// process.config is serialized config.gypi
const nativeModule = internalBinding('builtins');
const binding = internalBinding('builtins');

const processConfig = JSONParse(nativeModule.config, (_key, value) => {
const processConfig = JSONParse(binding.config, (_key, value) => {
// The `reviver` argument of the JSONParse method will visit all the values of
// the parsed config, including the "root" object, so there is no need to
// explicitly freeze the config outside of this method
Expand Down Expand Up @@ -288,7 +288,7 @@ const features = {
// This needs to be dynamic because --no-node-snapshot disables the
// code cache even if the binary is built with embedded code cache.
get cached_builtins() {
return nativeModule.hasCachedBuiltins();
return binding.hasCachedBuiltins();
}
};

Expand Down