Skip to content

[v18.x] lib: drop fetch experimental warning #45628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Richienb wants to merge 1 commit into from
Closed

[v18.x] lib: drop fetch experimental warning #45628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: drop fetch experimental warning 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #45287
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
  • Loading branch information
@mcollina @Richienb
mcollina authored and Richienb committed Nov 26, 2022
commit c71009d07a2604ff166a02bd906f5ecbb4fbccab
2 changes: 0 additions & 2 deletions lib/internal/process/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const {
const { reconnectZeroFillToggle } = require('internal/buffer');
const {
defineOperation,
emitExperimentalWarning,
exposeInterface,
} = require('internal/util');

Expand Down Expand Up @@ -212,7 +211,6 @@ function setupFetch() {
}

async function fetch(input, init = undefined) {
emitExperimentalWarning('The Fetch API');
return lazyUndici().fetch(input, init);
}

Expand Down
12 changes: 2 additions & 10 deletions test/parallel/test-fetch.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,9 @@ assert.strictEqual(typeof globalThis.Headers, 'function');
assert.strictEqual(typeof globalThis.Request, 'function');
assert.strictEqual(typeof globalThis.Response, 'function');

common.expectWarning(
'ExperimentalWarning',
'The Fetch API is an experimental feature. This feature could change at any time'
);

const server = http.createServer((req, res) => {
// TODO: Remove this once keep-alive behavior can be disabled from the client
// side.
res.setHeader('Keep-Alive', 'timeout=0, max=0');
const server = http.createServer(common.mustCall((req, res) => {
res.end('Hello world');
});
}));
server.listen(0);
await events.once(server, 'listening');
const port = server.address().port;
Expand Down