Skip to content

[v19.x] lib: fix eslint early return #45409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RafaelGSS wants to merge 1 commit into from
Closed

[v19.x] lib: fix eslint early return #45409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: fix eslint early return 
The #45243 upgraded eslint
and apparently, when you specific a `@returns` early returns
aren't considered valid. This PR fixes this lint issue.
  • Loading branch information
@RafaelGSS
RafaelGSS committed Nov 10, 2022
commit 8e21b8f45bb9efe35cb8bf2411c4d8dfb354893e
3 changes: 1 addition & 2 deletions lib/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1091,8 +1091,6 @@ function on(emitter, event, options) {
{ once: true });
}

return iterator;

function abortListener() {
errorHandler(new AbortError(undefined, { cause: signal?.reason }));
}
Expand Down Expand Up @@ -1120,4 +1118,5 @@ function on(emitter, event, options) {

iterator.return();
}
return iterator;
}