test: skip test-fs-largefile if not enough disk space by Trott · Pull Request #45339 · nodejs/node

Trott · 2022-11-06T15:55:11Z

I'm guessing this is the test that then causes other cascading disk failures, but maybe there are others. Let's run CI here and find out....

nodejs-github-bot · 2022-11-06T16:02:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47736/

Trott · 2022-11-06T16:35:23Z

My Jenkins CI didn't run out of space so I'm running just the macOS part of it again. I want to see that the test is actually skipped when ENOSPC happens. https://ci.nodejs.org/job/node-test-commit-osx/48467/

EDIT: And another one. https://ci.nodejs.org/job/node-test-commit-osx/48469/

EDIT: And one more. https://ci.nodejs.org/job/node-test-commit-osx/48470/

Trott · 2022-11-07T00:00:44Z

Here's another one: https://ci.nodejs.org/job/node-test-commit-osx/48483/

nodejs-github-bot · 2022-11-07T00:01:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47751/

Trott · 2022-11-07T01:50:33Z

Hooray, it caught a failure that time!

https://ci.nodejs.org/job/node-test-commit-osx/48483/nodes=osx1015/console

I think this is ready for review and landing.

@anonrig @nodejs/testing

anonrig

Perfect! Thanks @Trott. Can you apply the same changes to other tests too?

github-actions · 2022-11-07T17:12:02Z

Fast-track has been requested by @anonrig. Please 👍 to approve.

nodejs-github-bot · 2022-11-07T17:54:35Z

Commit Queue failed

- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T00:01:32Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3412750367

nodejs-github-bot · 2022-11-07T19:09:59Z

Commit Queue failed

- Loading data for nodejs/node/pull/45339
✔  Done loading data for nodejs/node/pull/45339
----------------------------------- PR info ------------------------------------
Title      test: skip test-fs-largefile if not enough disk space (#45339)
Author     Rich Trott  (@Trott)
Branch     Trott:fix-fs -> nodejs:main
Labels     test, fast-track, author ready, needs-ci
Commits    1
 - test: skip test-fs-largefile if not enough disk space
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45339
Fixes: https://github.com/nodejs/build/issues/3071
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Nitzan Uziely 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 06 Nov 2022 15:55:11 GMT
   ✔  Approvals: 2
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169721564
   ✔  - Nitzan Uziely (@linkgoron): https://github.com/nodejs/node/pull/45339#pullrequestreview-1169894956
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least one collaborator's approval (👍).
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-11-07T17:54:35Z: https://ci.nodejs.org/job/node-test-pull-request/47751/
- Querying data for job/node-test-pull-request/47751/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/3412750367

Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

Trott · 2022-11-07T19:12:59Z

Landed in e080331

Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2022

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 6, 2022

github-actions bot mentioned this pull request Nov 7, 2022

CI Reliability 2022-11-07 nodejs/reliability#421

Open

18 tasks

anonrig approved these changes Nov 7, 2022

View reviewed changes

anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 7, 2022

Linkgoron approved these changes Nov 7, 2022

View reviewed changes

anonrig added the fast-track PRs that do not need to wait for 72 hours to land. label Nov 7, 2022

anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 7, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 7, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 7, 2022

test: skip test-fs-largefile if not enough disk space

e080331

Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

Trott force-pushed the fix-fs branch from bc2bd73 to e080331 Compare November 7, 2022 19:12

Trott merged commit e080331 into nodejs:main Nov 7, 2022

Trott deleted the fix-fs branch November 7, 2022 19:13

github-actions bot mentioned this pull request Nov 8, 2022

CI Reliability 2022-11-08 nodejs/reliability#422

Open

17 tasks

github-actions bot mentioned this pull request Nov 9, 2022

CI Reliability 2022-11-09 nodejs/reliability#423

Open

14 tasks

lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022

test: skip test-fs-largefile if not enough disk space

51d301a

Fixes: nodejs/build#3071 PR-URL: nodejs#45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

github-actions bot mentioned this pull request Nov 10, 2022

CI Reliability 2022-11-10 nodejs/reliability#424

Open

20 tasks

RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022

test: skip test-fs-largefile if not enough disk space

717db1d

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

RafaelGSS mentioned this pull request Nov 10, 2022

v19.1.0 proposal #45269

Merged

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

test: skip test-fs-largefile if not enough disk space

6f9d993

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

danielleadams pushed a commit that referenced this pull request Dec 30, 2022

test: skip test-fs-largefile if not enough disk space

50358f1

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

danielleadams pushed a commit that referenced this pull request Jan 3, 2023

test: skip test-fs-largefile if not enough disk space

7e0332a

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

danielleadams pushed a commit that referenced this pull request Jan 4, 2023

test: skip test-fs-largefile if not enough disk space

d99e4b5

Fixes: nodejs/build#3071 PR-URL: #45339 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: skip test-fs-largefile if not enough disk space#45339

test: skip test-fs-largefile if not enough disk space#45339
Trott merged 1 commit intonodejs:mainfrom
Trott:fix-fs

Trott commented Nov 6, 2022

Uh oh!

nodejs-github-bot commented Nov 6, 2022

Uh oh!

Trott commented Nov 6, 2022 •

edited

Loading

Uh oh!

Trott commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

Trott commented Nov 7, 2022 •

edited

Loading

Uh oh!

anonrig left a comment

Uh oh!

github-actions bot commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

Trott commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

Trott commented Nov 6, 2022

Uh oh!

nodejs-github-bot commented Nov 6, 2022

Uh oh!

Trott commented Nov 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

Trott commented Nov 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

anonrig left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

nodejs-github-bot commented Nov 7, 2022

Uh oh!

Trott commented Nov 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Trott commented Nov 6, 2022 •

edited

Loading

Trott commented Nov 7, 2022 •

edited

Loading