Skip to content

buffer: fix validation of options in Blob constructor #45156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 5 commits into from
Oct 31, 2022
Merged

buffer: fix validation of options in Blob constructor #45156

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
138f0d7
buffer: fix validation of options in `Blob` constructor
aduh95 Oct 25, 2022
cfa1ef0
fixup! buffer: fix validation of options in `Blob` constructor
aduh95 Oct 25, 2022
e4dbc9e
add comment and link to the spec
aduh95 Oct 27, 2022
96230ee
update error message
aduh95 Oct 27, 2022
1ff33ff
fixup! buffer: fix validation of options in Blob constructor
aduh95 Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update error message
  • Loading branch information
@aduh95
aduh95 authored Oct 27, 2022
commit 96230ee286295825d4eab3d4b4eac0d1d1857c99
2 changes: 1 addition & 1 deletion lib/internal/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ const validateObject = hideStackFrames(
const validateDictionary = hideStackFrames(
(value, name) => {
if (value != null && typeof value !== 'object' && typeof value !== 'function') {
throw new ERR_INVALID_ARG_TYPE(name, 'Object or Function', value);
throw new ERR_INVALID_ARG_TYPE(name, 'a dictionary', value);
}
});

Expand Down