Skip to content

install: remove unused language files#45138

Closed
bnoordhuis wants to merge 1 commit intonodejs:mainfrom
bnoordhuis:rm-i18n-msi
Closed

install: remove unused language files#45138
bnoordhuis wants to merge 1 commit intonodejs:mainfrom
bnoordhuis:rm-i18n-msi

Conversation

@bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Oct 23, 2022

i18n in the Windows installer was disabled in 2016 for Reasons and never re-enabled.

There have been no complaints about lack of localization in the intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential contributor.

Refs: #45090

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Oct 23, 2022
@bnoordhuis
Copy link
Member Author

bnoordhuis commented Oct 23, 2022

"installer" has definitely been used in the past, silly bot.

@Trott
Copy link
Member

Trott commented Oct 24, 2022

"installer" has definitely been used in the past, silly bot.

If you want to add installer, we'll need to add it to https://github.com/nodejs/core-validate-commit/blob/a3cb753bc1a2d57457959ffd28578c2b44aa93a4/lib/rules/subsystem.js.

The installer subsystem hasn't been used in a commit message for over six years, though. It's probably easier to switch the commit message here to build (or tools).

@bnoordhuis
build: remove unused language files
0fa45f9 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: nodejs#45090
@bnoordhuis
Copy link
Member Author

bnoordhuis commented Oct 24, 2022

I took the path of least resistance and switched to build:

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 24, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47442/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 24, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/47449/

anonrig pushed a commit that referenced this pull request Oct 27, 2022
@bnoordhuis @anonrig
build: remove unused language files
9c13e05 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@anonrig
Copy link
Member

anonrig commented Oct 27, 2022

Landed in 9c13e05

@anonrig anonrig closed this Oct 27, 2022
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@bnoordhuis @RafaelGSS
build: remove unused language files
cccc873 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@bnoordhuis @RafaelGSS
build: remove unused language files
29b9f4f 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
build: remove unused language files
3418072 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@bnoordhuis @danielleadams
build: remove unused language files
e166dc5 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@bnoordhuis bnoordhuis mentioned this pull request Jan 2, 2023
Closed
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@bnoordhuis @danielleadams
build: remove unused language files
8a99221 
i18n in the Windows installer was disabled in 2016 for Reasons and never
re-enabled.

There have been no complaints about lack of localization in the
intervening years, suggesting there isn't a huge demand for it either.

Let's remove the files because it was confusing at least one potential
contributor.

Refs: #45090
PR-URL: #45138
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@daeyeon daeyeon daeyeon approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bnoordhuis @Trott @nodejs-github-bot @anonrig @jasnell @gengjiawen @daeyeon @aduh95