Skip to content

http: Add priority to common http headers#45045

Closed
jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell:add-http-priority-header
Closed

http: Add priority to common http headers#45045
jasnell wants to merge 1 commit intonodejs:mainfrom
jasnell:add-http-priority-header

Conversation

@jasnell
Copy link
Member

@jasnell jasnell commented Oct 17, 2022

The standard Priority header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell [email protected]

Extracted from the quic PR here: #44325

/cc @nodejs/http @nodejs/http2

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 17, 2022

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 17, 2022
@jasnell jasnell mentioned this pull request Oct 17, 2022
Closed
@jasnell jasnell force-pushed the add-http-priority-header branch from 424c4fe to c801c45 Compare October 17, 2022 22:11
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell commented Oct 17, 2022
View reviewed changes
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 17, 2022
@jasnell jasnell force-pushed the add-http-priority-header branch from c801c45 to 8b6d4ee Compare October 17, 2022 22:46
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
anonrig
anonrig approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mcollina
mcollina approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 18, 2022 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47323/ 💛

@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Oct 18, 2022
@jasnell
Copy link
Member Author

jasnell commented Oct 18, 2022

the github action asan test is failing for entirely unrelated reasons due to a flaky watch test

@github-actions github-actions bot mentioned this pull request Oct 19, 2022
Open
15 tasks
@jasnell
http: add priority to common http headers
7f311d9 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
@jasnell jasnell force-pushed the add-http-priority-header branch from 8b6d4ee to 7f311d9 Compare October 19, 2022 02:29
@jasnell jasnell added the fast-track PRs that do not need to wait for 72 hours to land. label Oct 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2022

Fast-track has been requested by @jasnell. Please 👍 to approve.

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 19, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 19, 2022

Commit Queue failed
- Loading data for nodejs/node/pull/45045
✔  Done loading data for nodejs/node/pull/45045
----------------------------------- PR info ------------------------------------
Title      http: Add priority to common http headers (#45045)
Author     James M Snell  (@jasnell)
Branch     jasnell:add-http-priority-header -> nodejs:main
Labels     c++, fast-track, author ready
Commits    1
 - http: add priority to common http headers
Committers 1
 - James M Snell 
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45045
Reviewed-By: Antoine du Hamel 
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Matteo Collina 
Reviewed-By: Robert Nagy 
Reviewed-By: Rafael Gonzaga 
Reviewed-By: Darshan Sen 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - http: add priority to common http headers
   ℹ  This PR was created on Mon, 17 Oct 2022 22:05:13 GMT
   ✔  Approvals: 6
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1144864402
   ✔  - Yagiz Nizipli (@anonrig): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145011496
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145108209
   ✔  - Robert Nagy (@ronag) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145112248
   ✔  - Rafael Gonzaga (@RafaelGSS): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145659186
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45045#pullrequestreview-1145900509
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2022-10-18T14:39:41Z: https://ci.nodejs.org/job/node-test-pull-request/47323/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - http: add priority to common http headers
- Querying data for job/node-test-pull-request/47323/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3282243031

@jasnell
Copy link
Member Author

jasnell commented Oct 19, 2022

Landed in 112bf50

@jasnell jasnell closed this Oct 19, 2022
jasnell added a commit that referenced this pull request Oct 19, 2022
@jasnell
http: add priority to common http headers
112bf50 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
This was referenced Oct 20, 2022
Open
Open
Open
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@jasnell @RafaelGSS
http: add priority to common http headers
e52a049 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@jasnell @RafaelGSS
http: add priority to common http headers
8abc3f7 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@jasnell @danielleadams
http: add priority to common http headers
8f1b639 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@jasnell @danielleadams
http: add priority to common http headers
4b93fda 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@jasnell @danielleadams
http: add priority to common http headers
f222c95 
The standard `Priority` header is defined in RFC 9218.

This is added as part of the precusor to quic/http3 work.

Signed-off-by: James M Snell <[email protected]>
PR-URL: #45045
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Robert Nagy <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@anonrig anonrig anonrig approved these changes

@ronag ronag ronag approved these changes

@aduh95 aduh95 aduh95 approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@jasnell @nodejs-github-bot @mcollina @anonrig @ronag @aduh95 @RafaelGSS @RaisinTen

Comments