Skip to content

src: consolidate exit codes in the code base #44746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Oct 6, 2022
Merged

src: consolidate exit codes in the code base #44746

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fa76b0d
src: consolidate exit codes in the code base
joyeecheung Sep 22, 2022
b439af8
fixup! src: consolidate exit codes in the code base
joyeecheung Sep 28, 2022
00e91e3
fixup! fixup! src: consolidate exit codes in the code base
joyeecheung Sep 29, 2022
dbb1e5a
fixup! fixup! fixup! src: consolidate exit codes in the code base
joyeecheung Sep 29, 2022
15d3fde
fixup! fixup! fixup! fixup! src: consolidate exit codes in the code base
joyeecheung Oct 3, 2022
bd027f1
fixup! fixup! fixup! fixup! fixup! src: consolidate exit codes in the…
joyeecheung Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! fixup! fixup! fixup! src: consolidate exit codes in the code base
  • Loading branch information
@joyeecheung
joyeecheung committed Oct 3, 2022
commit 15d3fded99b8123a604fbe82f682dfd5ee053a2b
13 changes: 7 additions & 6 deletions src/node_exit_code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
namespace node {
#define EXIT_CODE_LIST(V) \
V(NoFailure, 0) \
/* This was intended for uncaught JS exceptions from the user land but we */ \
/* 1 was intended for uncaught JS exceptions from the user land but we */ \
/* actually use this for all kinds of generic errors. */ \
V(GenericUserError, 1) \
/* 2 is unused */ \
Expand All @@ -28,11 +28,12 @@ namespace node {
/* just a duplicate of InvalidCommandLineArgument */ \
V(InvalidCommandLineArgument2, 12) \
V(UnfinishedTopLevelAwait, 13) \
V(StartupSnapshotFailure, 14)

// If the process exits from unhandled signals e.g. SIGABRT, SIGTRAP, typically
// the exit codes are 128 + signal number. We also exit with certain error
// codes directly for legacy reasons.
V(StartupSnapshotFailure, 14) \
/* If the process exits from unhandled signals e.g. SIGABRT, SIGTRAP, */ \
/* typically the exit codes are 128 + signal number. We also exit with */ \
/* certain error codes directly for legacy reasons. Here we define those */ \
/* that are used to normalize the exit code on Windows. */ \
V(Abort, 134)

// TODO(joyeecheung): expose this to user land when the codes are stable.
// The underlying type should be an int, or we can get undefined behavior when
Expand Down