lib: don't match sourceMappingURL in strings

Prior to this change `sourceMappingURL` in string where being matched by the RegExp which caused sourcemaps not be loaded when using the `--enable-source-maps` flag. This commit changes the RegExp to match the last occurrence. Fixes: #44654
nodejs · alan-agius4 · Sep 16, 2022 · Sep 16, 2022 · Sep 18, 2022 · Sep 16, 2022
commit 680947cf478c16723c30923e941deb409fba294c
diff --git a/lib/internal/source_map/source_map_cache.js b/lib/internal/source_map/source_map_cache.js
@@ -41,8 +41,8 @@ const esmSourceMapCache = new SafeMap();
 // The generated sources is not mutable, so we can use a Map without memory concerns:
 const generatedSourceMapCache = new SafeMap();
 const kLeadingProtocol = /^\w+:\/\//;
-const kSourceMappingURLMagicComment = /\/[*/]#\s+sourceMappingURL=(?<sourceMappingURL>[^\s]+)/;
-const kSourceURLMagicComment = /\/[*/]#\s+sourceURL=(?<sourceURL>[^\s]+)/;
+const kSourceMappingURLMagicComment = /\/[*/]#\s+sourceMappingURL=(?<sourceMappingURL>[^\s]+)/g;
+const kSourceURLMagicComment = /\/[*/]#\s+sourceURL=(?<sourceURL>[^\s]+)/g;
 
 const { fileURLToPath, pathToFileURL, URL } = require('internal/url');
 let SourceMap;
@@ -80,11 +80,12 @@ function setSourceMapsEnabled(val) {
 }
 
 function extractSourceURLMagicComment(content) {
-  const matchSourceURL = RegExpPrototypeExec(
-    kSourceURLMagicComment,
-    content
-  );
-  if (matchSourceURL === null) {
+  let match;
+  let matchSourceURL;
+  while ((match = RegExpPrototypeExec(kSourceURLMagicComment, content))) {
+    matchSourceURL = match;
+  }
+  if (matchSourceURL == null) {
     return null;
   }
   let sourceURL = matchSourceURL.groups.sourceURL;
@@ -104,13 +105,19 @@ function maybeCacheSourceMap(filename, content, cjsModuleInstance, isGeneratedSo
     debug(err);
     return;
   }
-  const match = RegExpPrototypeExec(kSourceMappingURLMagicComment, content);
+
+  let match;
+  let lastMatch;
+  while ((match = RegExpPrototypeExec(kSourceMappingURLMagicComment, content))) {
+    lastMatch = match;
+  }
+
   if (sourceURL === undefined) {
     sourceURL = extractSourceURLMagicComment(content);
   }
-  if (match) {
-    const data = dataFromUrl(filename, match.groups.sourceMappingURL);
-    const url = data ? null : match.groups.sourceMappingURL;
+  if (lastMatch) {
+    const data = dataFromUrl(filename, lastMatch.groups.sourceMappingURL);
+    const url = data ? null : lastMatch.groups.sourceMappingURL;
     if (cjsModuleInstance) {
       cjsSourceMapCache.set(cjsModuleInstance, {
         filename,

diff --git a/test/fixtures/source-map/typescript-sourcemapping_url_string.js b/test/fixtures/source-map/typescript-sourcemapping_url_string.js
diff --git a/test/fixtures/source-map/typescript-sourcemapping_url_string.js.map b/test/fixtures/source-map/typescript-sourcemapping_url_string.js.map
diff --git a/test/message/source_map_sourcemapping_url_string.js b/test/message/source_map_sourcemapping_url_string.js
@@ -0,0 +1,13 @@
+// Flags:  --enable-source-maps
+
+'use strict';
+require('../common');
+Error.stackTraceLimit = 2;
+
+try {
+  require('../fixtures/source-map/typescript-sourcemapping_url_string');
+} catch (err) {
+  setTimeout(() => {
+    console.info(err);
+  }, 10);
+}
diff --git a/test/message/source_map_sourcemapping_url_string.out b/test/message/source_map_sourcemapping_url_string.out
@@ -0,0 +1,3 @@
+Error: an exception.
+    at *typescript-sourcemapping_url_string.ts:3:7*
+    at Module._compile (node:internal/modules/cjs/loader:1129:14)