test_runner: add --test-name-pattern CLI flag#44508
Closed
cjihrig wants to merge 3 commits intonodejs:mainfrom
Closed
test_runner: add --test-name-pattern CLI flag#44508cjihrig wants to merge 3 commits intonodejs:mainfrom
cjihrig wants to merge 3 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
c++
MoLow
reviewed
Sep 4, 2022
Member
|
we will probably want to add this as an option to |
cjihrig
added
the
semver-minor
cjihrig
force-pushed
the
test-name-pattern
branch
from
11bd5fe to
7180c1d
Compare
MoLow
reviewed
Oct 2, 2022
MoLow
reviewed
Oct 2, 2022
MoLow
approved these changes
Oct 2, 2022
Member
MoLow
left a comment
MoLow
left a comment
There was a problem hiding this comment.
LGTM. added non-blocking comments
jasnell
approved these changes
Oct 2, 2022
This commit adds support for running tests that match a regular expression. Fixes: nodejs#42984
cjihrig
force-pushed
the
test-name-pattern
branch
from
7180c1d to
2ae9559
Compare
MoLow
approved these changes
Oct 2, 2022
Collaborator
Collaborator
Collaborator
Collaborator
16 tasks
cjihrig
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/44508 ✔ Done loading data for nodejs/node/pull/44508 ----------------------------------- PR info ------------------------------------ Title test_runner: add --test-name-pattern CLI flag (#44508) Author Colin Ihrig (@cjihrig) Branch cjihrig:test-name-pattern -> nodejs:main Labels c++, semver-minor, dont-land-on-v14.x, commit-queue-squash, test_runner Commits 3 - test_runner: add --test-name-pattern CLI flag - more tests more better - update node.1 Committers 1 - cjihrig PR-URL: https://github.com/nodejs/node/pull/44508 Fixes: https://github.com/nodejs/node/issues/42984 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44508 Fixes: https://github.com/nodejs/node/issues/42984 Reviewed-By: Moshe Atlow Reviewed-By: James M Snell -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - update node.1 ℹ This PR was created on Sat, 03 Sep 2022 21:19:34 GMT ✔ Approvals: 2 ✔ - Moshe Atlow (@MoLow): https://github.com/nodejs/node/pull/44508#pullrequestreview-1127666293 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/44508#pullrequestreview-1127626541 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-03T19:38:53Z: https://ci.nodejs.org/job/node-test-pull-request/47046/ - Querying data for job/node-test-pull-request/47046/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3182397015 |
Contributor
Author
|
Landed in 87170c3 |
This was referenced Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds support for running tests that match a regular expression.
Fixes: #42984