Skip to content

gyp: libnode for ios app embedding #44210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gengjiawen merged 3 commits into from
Sep 21, 2022
Merged

gyp: libnode for ios app embedding #44210

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d19c5e
build libnode for ios app embedding
chexiongsheng Aug 10, 2022
66347c7
revert change to gyp
chexiongsheng Aug 25, 2022
d105434
fix some style issues
chexiongsheng Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix some style issues
  • Loading branch information
@chexiongsheng
chexiongsheng committed Aug 29, 2022
commit d105434599fc756d62a205b60f7669f95a12f561
6 changes: 4 additions & 2 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,8 @@
'conditions': [
['v8_enable_webassembly==1', {
'conditions': [
['OS=="mac" or OS=="ios" or (_toolset=="host" and host_arch=="x64" and (host_os=="linux" or host_os=="mac"))', {
['OS=="mac" or OS=="ios" or '
'(_toolset=="host" and host_arch=="x64" and (host_os=="linux" or host_os=="mac"))', {
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-inside-posix.cc',
'<(V8_ROOT)/src/trap-handler/handler-outside-posix.cc',
Expand All @@ -861,7 +862,8 @@
],
}],
# TODO(targos): Replace False with OS=="win" if handler-outside-simulator.cc becomes compatible with MSVC.
['_toolset=="host" and host_arch=="x64" and (host_os=="linux" or host_os=="mac" or False)', {
['_toolset=="host" and host_arch=="x64" and '
'(host_os=="linux" or host_os=="mac" or False)', {
'sources': [
'<(V8_ROOT)/src/trap-handler/handler-outside-simulator.cc',
],
Expand Down