Skip to content

lib: improve hideStackFrames intellisense #44181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 11 commits into from
Aug 17, 2022
Merged

lib: improve hideStackFrames intellisense #44181

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
16d2a85
lib: improve hideStackFrames intellisense
anonrig Aug 8, 2022
21e8903
lib: update validator jdoc declarations
anonrig Aug 16, 2022
7364ab9
lib: add missing null default value to validateObject
anonrig Aug 16, 2022
a999fa6
lib: add missing return due to jsdoc/require-returns-check
anonrig Aug 16, 2022
3b6d180
lib: replace functions with callbacks on jsdoc
anonrig Aug 17, 2022
4c4c46a
lib: update according to feedback
anonrig Aug 17, 2022
ee0ab2a
lib: add missing optional jsdoc to validateSignalName
anonrig Aug 17, 2022
62fde49
lib: fix wrong jsdoc for validateUint32
anonrig Aug 17, 2022
b47611f
lib: suppress eslint rule for jsdoc
anonrig Aug 17, 2022
49db869
lib: make number validation input any
anonrig Aug 17, 2022
0c9fbc5
lib: add missing assertions
anonrig Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lib: add missing null default value to validateObject
  • Loading branch information
@anonrig
anonrig committed Aug 16, 2022
commit 7364ab99fb1ffca398716ee7d5b866b32222045b
2 changes: 1 addition & 1 deletion lib/internal/validators.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function getOwnPropertyValueOrDefault(options, key, defaultValue) {
* @param {{allowArray: boolean=, allowFunction: boolean=, nullable: boolean=}} [options]
*/
const validateObject = hideStackFrames(
(value, name, options) => {
(value, name, options = null) => {
const allowArray = getOwnPropertyValueOrDefault(options, 'allowArray', false);
const allowFunction = getOwnPropertyValueOrDefault(options, 'allowFunction', false);
const nullable = getOwnPropertyValueOrDefault(options, 'nullable', false);
Expand Down