Skip to content

[v14.x backport] deps: update corepack to 0.14.1#43760

Closed
aduh95 wants to merge 8 commits intonodejs:v14.x-stagingfrom
aduh95:backport-corepack-updates
Closed

[v14.x backport] deps: update corepack to 0.14.1#43760
aduh95 wants to merge 8 commits intonodejs:v14.x-stagingfrom
aduh95:backport-corepack-updates

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jul 10, 2022 •
edited
Loading

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. v14.x labels Jul 10, 2022
arcanis and others added 2 commits July 19, 2022 19:44
@arcanis @aduh95
deps: update Corepack to 0.11.2
38ca655 
PR-URL: nodejs#43402
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@nodejs-github-bot @aduh95
deps: update corepack to 0.12.0
21e45c8 
PR-URL: nodejs#43748
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
@aduh95 aduh95 force-pushed the backport-corepack-updates branch from dec6cda to 21e45c8 Compare July 19, 2022 17:49
@nodejs-github-bot @aduh95
deps: update corepack to 0.12.1
9fc2121 
PR-URL: nodejs#43965
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
@aduh95 aduh95 changed the title [v14.x backport] deps: update corepack to 0.12.0 [v14.x backport] deps: update corepack to 0.12.1 Jul 24, 2022
F3n67u
F3n67u approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@F3n67u F3n67u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@F3n67u F3n67u added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 25, 2022
@F3n67u F3n67u added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jul 25, 2022
@richardlau
Copy link
Member

richardlau commented Jul 25, 2022

FWIW I don't believe the commit queue works for any branch other than main. For one thing when https://github.com/nodejs/node/blob/main/.github/workflows/commit-queue.yml is run on the cron timer I believe github.ref_name is always refs/heads/main so the PR list is always filtered to PR's with a base branch of main. A second blocker would be that the github bot user isn't a backporter so can't land things on the staging branch.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 25, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 25, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/45675/

@F3n67u F3n67u removed commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. labels Jul 25, 2022
@F3n67u
Copy link
Contributor

F3n67u commented Jul 25, 2022

FWIW I don't believe the commit queue works for any branch other than main. For one thing when https://github.com/nodejs/node/blob/main/.github/workflows/commit-queue.yml is run on the cron timer I believe github.ref_name is always refs/heads/main so the PR list is always filtered to PR's with a base branch of main. A second blocker would be that the github bot user isn't a backporter so can't land things on the staging branch.

Got it. Removed the commit-queue label.

This was referenced Jul 26, 2022
Open
Open
Open
@nodejs-github-bot @aduh95
deps: update corepack to 0.12.2
ba1040c 
PR-URL: nodejs#44159
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
@aduh95 aduh95 changed the title [v14.x backport] deps: update corepack to 0.12.1 [v14.x backport] deps: update corepack to 0.12.3 Aug 15, 2022
@nodejs-github-bot @aduh95
deps: update corepack to 0.12.3
3e58874 
PR-URL: nodejs#44229
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@nodejs-github-bot @aduh95
deps: update corepack to 0.13.0
9a269a4 
PR-URL: nodejs#44318
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 aduh95 changed the title [v14.x backport] deps: update corepack to 0.12.3 [v14.x backport] deps: update corepack to 0.13.0 Aug 21, 2022
@aduh95 aduh95 changed the title [v14.x backport] deps: update corepack to 0.13.0 [v14.x backport] deps: update corepack to 0.14.0 Sep 5, 2022
@nodejs-github-bot @aduh95
deps: update corepack to 0.14.0
8dd83aa 
PR-URL: nodejs#44509
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@aduh95 aduh95 changed the title [v14.x backport] deps: update corepack to 0.14.0 [v14.x backport] deps: update corepack to 0.14.1 Sep 18, 2022
@nodejs-github-bot @aduh95
deps: update corepack to 0.14.1
952058c 
PR-URL: nodejs#44704
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@arcanis @danielleadams
deps: update Corepack to 0.11.2
fa6c276 
PR-URL: #43402
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.12.0
9d6cb3b 
PR-URL: #43748
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.12.1
b6972c9 
PR-URL: #43965
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mestery <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.12.2
28e9891 
PR-URL: #44159
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.12.3
ee24c32 
PR-URL: #44229
Backport-PR-URL: #43760
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.13.0
0227462 
PR-URL: #44318
Backport-PR-URL: #43760
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.14.0
e55389c 
PR-URL: #44509
Backport-PR-URL: #43760
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
danielleadams pushed a commit that referenced this pull request Oct 1, 2022
@nodejs-github-bot @danielleadams
deps: update corepack to 0.14.1
a1f8e4d 
PR-URL: #44704
Backport-PR-URL: #43760
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@danielleadams
Copy link
Contributor

danielleadams commented Oct 1, 2022

Landed in 4f83d75...a1f8e4d

@aduh95 aduh95 deleted the backport-corepack-updates branch October 8, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawen gengjiawen gengjiawen approved these changes

@trivikr trivikr trivikr approved these changes

+2 more reviewers

@F3n67u F3n67u F3n67u approved these changes

@Mesteery Mesteery Mesteery approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aduh95 @richardlau @nodejs-github-bot @F3n67u @danielleadams @gengjiawen @trivikr @Mesteery @arcanis

Comments