Skip to content

stream: fix 0 transform hwm backpressure #43685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 16 commits into from
Jul 24, 2022
Merged

stream: fix 0 transform hwm backpressure #43685

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
446aba6
stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
67eaa2f
stream: add 0 hwm test
kanongil Jul 5, 2022
4688771
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
7b758da
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
150c51b
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
2d5a05f
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
63e4e53
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
ac2c5b3
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
3654d6e
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
386f2ec
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 5, 2022
f93c687
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 6, 2022
f00b475
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 6, 2022
a6b4423
fixup! stream: fix 0 transform hwm backpressure
ronag Jul 6, 2022
e3603d3
fixup! stream: add 0 hwm test
ronag Jul 6, 2022
71d66ec
fixup
ronag Jul 6, 2022
b426a13
fixup: allow overriding writableHighWaterMark
ronag Jul 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! stream: fix 0 transform hwm backpressure
  • Loading branch information
@ronag
ronag committed Jul 5, 2022
commit 150c51b95c243ebf1debca9fb928bdde0680444a
3 changes: 3 additions & 0 deletions lib/internal/streams/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,9 @@ function Transform(options) {
// TODO (ronag): This should preferably always be
// applied but would be semver-major.
if (options && options.highWaterMark === 0) {
// A Duplex will buffer both on the writable and readable side while
// a Transform just wants to buffer hwm number of elements. To avoid
// buffering twice we disable buffering on the writable side.
options = {
...options,
highWaterMark: null,
Expand Down