Skip to content

test: refactor into async-await #43292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Jun 4, 2022
Merged

test: refactor into async-await #43292

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a6c4a7c
test: convert then to async/await
meekdenzo May 28, 2022
6d6f458
test: fix unrelated changes
meekdenzo May 28, 2022
c62c79d
test: modify then to async/await
meekdenzo May 28, 2022
14c20f5
test: confirm rebase with dummy comment
meekdenzo Jun 1, 2022
b5de072
test: remove dummy comment
meekdenzo Jun 1, 2022
4786bf0
test: refactor into async-await
meekdenzo Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix unrelated changes
  • Loading branch information
@meekdenzo
meekdenzo committed Jun 1, 2022
commit 6d6f4584e0e91aba38cf9db6c451b7b4e858fe04
6 changes: 0 additions & 6 deletions src/inspector/main_thread_interface.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,12 +288,6 @@ Deletable* MainThreadInterface::GetObjectIfExists(int id) {
return iterator->second.get();
}


// v8::Isolate *isolate = v8::Isolate::TryGetCurrent();
// CHECK_NOT_NULL(isolate);
// uint16_t *buffer;
// v8::String::NewFromUtf8(isolate, message.data())->Write(buffer);

std::unique_ptr<StringBuffer> Utf8ToStringView(const std::string& message) {
icu::UnicodeString utf16 = icu::UnicodeString::fromUTF8(
icu::StringPiece(message.data(), message.length()));
Expand Down