Skip to content

test: remove the legacy url parser function in inspector-helper.js #42656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
Apr 14, 2022
Merged

test: remove the legacy url parser function in inspector-helper.js #42656

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test: remove the legacy url parser function
  • Loading branch information
@cola119
cola119 committed Apr 8, 2022
commit e8d24bfb6c2c1bd11031c7db29039844af6be52e
5 changes: 2 additions & 3 deletions test/common/inspector-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,7 @@ const fs = require('fs');
const http = require('http');
const fixtures = require('../common/fixtures');
const { spawn } = require('child_process');
const { parse: parseURL } = require('url');
const { pathToFileURL } = require('url');
const { URL, pathToFileURL } = require('url');
const { EventEmitter } = require('events');

const _MAINSCRIPT = fixtures.path('loop.js');
Expand Down Expand Up @@ -418,7 +417,7 @@ class NodeInstance extends EventEmitter {
return http.get({
port,
family: 4,
path: parseURL(devtoolsUrl).path,
path: new URL(devtoolsUrl).pathname,
headers: {
'Connection': 'Upgrade',
'Upgrade': 'websocket',
Expand Down