Skip to content

bootstrap: support configure-time user-land snapshot #42466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 8 commits into from
Closed

bootstrap: support configure-time user-land snapshot #42466

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
208d047
bootstrap: refresh options in pre-execution
joyeecheung Jun 11, 2021
4d59a74
build: add --node-snapshot-main configure option
joyeecheung Mar 24, 2022
c812b98
bootstrap: make I/O streams work with user-land snapshot
joyeecheung Mar 25, 2022
39cd563
bootstrap: run inspector and event loop in snapshot builder
joyeecheung Mar 24, 2022
da8c19f
fixup! build: add --node-snapshot-main configure option
joyeecheung Mar 26, 2022
b1f934f
bootsrap: reset process._exit and process.exitCode in pre-execution
joyeecheung Mar 26, 2022
4d0500d
fixup! build: add --node-snapshot-main configure option
joyeecheung Mar 28, 2022
25f4c8d
fixup! bootstrap: run inspector and event loop in snapshot builder
joyeecheung Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! bootstrap: run inspector and event loop in snapshot builder
  • Loading branch information
@joyeecheung
joyeecheung committed Mar 28, 2022
commit 25f4c8dedd18704b3ad8ee2a620570be7d7b3bc3
6 changes: 3 additions & 3 deletions src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,9 @@ void SnapshotBuilder::Generate(SnapshotData* out,
PrintCaughtException(isolate, context, bootstrapCatch);
}
result.ToLocalChecked();
// FIXME(joyee): right now running the loop in the snapshot builder
// seems to intrudoces inconsistencies in JS land that need to be
// synchronized again after snapshot restoration.
// FIXME(joyeecheung): right now running the loop in the snapshot
// builder seems to introduces inconsistencies in JS land that need to
// be synchronized again after snapshot restoration.
int exit_code = SpinEventLoop(env).FromMaybe(1);
CHECK_EQ(exit_code, 0);
if (bootstrapCatch.HasCaught()) {
Expand Down