Skip to content

doc: fix bug in stream doc unshift example #41944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 1 commit into from
Feb 15, 2022
Merged

doc: fix bug in stream doc unshift example #41944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: fix bug in stream doc, unshift example
  • Loading branch information
@meixg
meixg committed Feb 12, 2022
commit 028779b9ec948c1730c7eec5fb18a4061aaad797
8 changes: 4 additions & 4 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1586,7 +1586,7 @@ function parseHeader(stream, callback) {
let chunk;
while (null !== (chunk = stream.read())) {
const str = decoder.write(chunk);
if (str.match(/\n\n/)) {
if (str.includes('\n\n')) {
// Found the header boundary.
const split = str.split(/\n\n/);
header += split.shift();
Expand All @@ -1599,10 +1599,10 @@ function parseHeader(stream, callback) {
stream.unshift(buf);
// Now the body of the message can be read from the stream.
callback(null, header, stream);
} else {
// Still reading the header.
header += str;
return;
}
// Still reading the header.
header += str;
}
}
}
Expand Down