Skip to content

src: fix and cleanup URL::SerializeURL #41759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

src: fix and cleanup URL::SerializeURL #41759

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b47430c
src: fix query/fragment serialization in URL::SerializeURL
addaleax Jan 29, 2022
c9ea544
src: reserve string allocation space early in URL::SerializeURL
addaleax Jan 29, 2022
2fe8dcf
src: use const reference instead of pointer in URL::SerializeURL
addaleax Jan 29, 2022
438849a
fixup! src: use const reference instead of pointer in URL::SerializeURL
addaleax Jan 31, 2022
6552e41
fixup! src: use const reference instead of pointer in URL::SerializeURL
addaleax Jan 31, 2022
08ec1d5
fixup! src: use const reference instead of pointer in URL::SerializeURL
addaleax Feb 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: fix query/fragment serialization in URL::SerializeURL 
These are presumably typos.
  • Loading branch information
@addaleax
addaleax committed Jan 29, 2022
commit b47430c842d0f79342d8af3e89fa99b8cc3510b5
4 changes: 2 additions & 2 deletions src/node_url.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1578,10 +1578,10 @@ std::string URL::SerializeURL(const struct url_data* url,
}
}
if (url->flags & URL_FLAGS_HAS_QUERY) {
output = "?" + url->query;
output += "?" + url->query;
}
if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {
output = "#" + url->fragment;
output += "#" + url->fragment;
}
return output;
}
Expand Down