Skip to content

src: slightly simplify V8CoverageConnection::GetFilename #41748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 1 commit into from
Closed

src: slightly simplify V8CoverageConnection::GetFilename #41748

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: slightly simplify V8CoverageConnection::GetFilename
  • Loading branch information
@addaleax
addaleax committed Jan 29, 2022
commit 21b2c4f20ece048c59be1be4fc33190594ece7fa
18 changes: 6 additions & 12 deletions src/inspector_profiler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,18 +170,12 @@ static bool EnsureDirectory(const std::string& directory, const char* type) {
}

std::string V8CoverageConnection::GetFilename() const {
std::string thread_id = std::to_string(env()->thread_id());
std::string pid = std::to_string(uv_os_getpid());
std::string timestamp = std::to_string(
static_cast<uint64_t>(GetCurrentTimeInMicroseconds() / 1000));
char filename[1024];
snprintf(filename,
sizeof(filename),
"coverage-%s-%s-%s.json",
pid.c_str(),
timestamp.c_str(),
thread_id.c_str());
return filename;
uint64_t timestamp =
static_cast<uint64_t>(GetCurrentTimeInMicroseconds() / 1000);
return SPrintF("coverage-%s-%s-%s.json",
uv_os_getpid(),
timestamp,
env()->thread_id());
}

void V8ProfilerConnection::WriteProfile(Local<Object> result) {
Expand Down