Closed
Conversation
Member
Author
|
I'll land once I get through the onboarding steps (assuming there are enough approvals/waiting time is complete by then) |
richardlau
approved these changes
Jan 6, 2022
aduh95
approved these changes
Jan 6, 2022
Member
Author
|
Believe we can fast track this. |
Contributor
|
Fast-track has been requested by @mhdawson. Please 👍 to approve. |
apapirovski
approved these changes
Jan 6, 2022
Contributor
There was a problem hiding this comment.
Now that we have the vote directory in nodejs/tsc, should we create that PR first and then reference it here?
Although I guess the json is mostly for bookkeeping, since the vote happens in the issue thread... which makes me think, should our votes just be PRs against the TSC repo? Would simplify the automation too.
Edit: I suppose upon further reflection, a decent % of our votes are not binary which would make the PR format not particularly helpful.
Contributor
|
(updated the title to match the other PR, there was an error in the name) |
Member
@mhdawson The commit title would need to be updated as well. |
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]>
Member
Author
|
@richardlau fixed |
gireeshpunathil
approved these changes
Jan 7, 2022
Trott
approved these changes
Jan 7, 2022
bnb
approved these changes
Jan 7, 2022
BethGriggs
approved these changes
Jan 7, 2022
mmarchini
approved these changes
Jan 7, 2022
Member
Author
|
Ok, added to all required groups, created PRs to add to emails. |
mhdawson
added a commit
that referenced
this pull request
Jan 7, 2022
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Member
Author
|
Landed in 46f4d5e |
Member
Author
|
@RaisinTen Welcome ! |
targos
pushed a commit
that referenced
this pull request
Jan 14, 2022
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: nodejs#41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
Refs: nodejs/TSC#1141 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #41419 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Tierney Cyren <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Mary Marchini <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/TSC#1141
Signed-off-by: Michael Dawson [email protected]