Skip to content

src: improve MakeCallback() performance #41331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
addaleax wants to merge 6 commits into from
Closed

src: improve MakeCallback() performance #41331

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bb0bd36
src: guard slightly costly check in MakeCallback more strongly
addaleax Dec 26, 2021
f97d04e
src: store native async execution resources as `v8::Local`
addaleax Dec 26, 2021
853853f
src: split out async stack corruption detection from inline fn
addaleax Dec 26, 2021
b98e4bd
fixup! src: guard slightly costly check in MakeCallback more strongly
addaleax Dec 26, 2021
069373e
fixup! src: store native async execution resources as `v8::Local`
addaleax Dec 26, 2021
a7787bb
fixup! src: store native async execution resources as `v8::Local`
addaleax Dec 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! src: store native async execution resources as v8::Local
  • Loading branch information
@addaleax
addaleax committed Dec 28, 2021
commit a7787bbcabeeb8b63889c7baffdabb208ace999e
10 changes: 7 additions & 3 deletions src/env.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1113,6 +1113,8 @@ void AsyncHooks::Deserialize(Local<Context> context) {
// were entered. We cannot recreate this here; however, storing these values
// on the JS equivalent gives the same result, so we do that instead.
for (size_t i = 0; i < info_->native_execution_async_resources.size(); ++i) {
if (info_->native_execution_async_resources[i] == SIZE_MAX)
continue;
Local<Object> obj = context->GetDataFromSnapshotOnce<Object>(
info_->native_execution_async_resources[i])
.ToLocalChecked();
Expand Down Expand Up @@ -1162,9 +1164,11 @@ AsyncHooks::SerializeInfo AsyncHooks::Serialize(Local<Context> context,
info.native_execution_async_resources.resize(
native_execution_async_resources_.size());
for (size_t i = 0; i < native_execution_async_resources_.size(); i++) {
info.native_execution_async_resources[i] = creator->AddData(
context,
native_execution_async_resources_[i]);
info.native_execution_async_resources[i] =
native_execution_async_resources_[i].IsEmpty() ? SIZE_MAX :
creator->AddData(
context,
native_execution_async_resources_[i]);
}
CHECK_EQ(contexts_.size(), 1);
CHECK_EQ(contexts_[0], env()->context());
Expand Down