Skip to content

util: make sure error causes of any type may be inspected #41097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BridgeAR wants to merge 2 commits into from
Closed

util: make sure error causes of any type may be inspected #41097

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd03389
util: make sure error causes of any type may be inspected
BridgeAR Dec 6, 2021
38fc7f8
util: serialize falsy cause values while inspecting errors
BridgeAR Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
util: serialize falsy cause values while inspecting errors 
Signed-off-by: Ruben Bridgewater <[email protected]>
  • Loading branch information
@BridgeAR
BridgeAR committed Dec 6, 2021
commit 38fc7f86a0bfe7a2cea96e763495331abdc7e74b
3 changes: 2 additions & 1 deletion lib/internal/util/inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1265,7 +1265,8 @@ function formatError(err, constructor, tag, ctx, keys) {

removeDuplicateErrorKeys(ctx, keys, err, stack);

if (err.cause && (keys.length === 0 || !keys.includes('cause'))) {
if (err.cause !== undefined &&
(keys.length === 0 || !keys.includes('cause'))) {
keys.push('cause');
}

Expand Down
10 changes: 10 additions & 0 deletions test/parallel/test-util-inspect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,16 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
assert(ex.includes('[message]'));
}

{
const falsyCause1 = new Error('', { cause: false });
delete falsyCause1.stack;
const falsyCause2 = new Error(undefined, { cause: null });
falsyCause2.stack = '';

assert.strictEqual(util.inspect(falsyCause1), '[Error] { [cause]: false }');
assert.strictEqual(util.inspect(falsyCause2), '[Error] { [cause]: null }');
}

{
const tmp = Error.stackTraceLimit;
Error.stackTraceLimit = 0;
Expand Down