Skip to content

readline: skip escaping characters again #41005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Dec 1, 2021
Merged

readline: skip escaping characters again #41005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
readline: skip escaping characters again 
This is a minor performance improvement for readline. It skips to
escape individual characters again after escaping them before.

Signed-off-by: Ruben Bridgewater <[email protected]>
  • Loading branch information
@BridgeAR
BridgeAR committed Nov 28, 2021
commit eb675107c5256a7a3bef4beaecd3b934d7e8eb26
2 changes: 1 addition & 1 deletion lib/internal/readline/interface.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,7 +862,7 @@ class Interface extends InterfaceConstructor {
offset += this.tabSize - (offset % this.tabSize);
continue;
}
const width = getStringWidth(char);
const width = getStringWidth(char, false /* stripVTControlCharacters */);
if (width === 0 || width === 1) {
offset += width;
} else {
Expand Down