Skip to content

stream: drain Transform with 0 highWaterMark #40947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 2 commits into from
Closed

stream: drain Transform with 0 highWaterMark #40947

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4453b0
stream: drain Transform with 0 highWaterMark
ronag Nov 24, 2021
f88c666
Update test/parallel/test-stream-passthrough-drain.js
ronag Nov 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: drain Transform with 0 highWaterMark 
Fixes: #40935
  • Loading branch information
@ronag
ronag committed Nov 24, 2021
commit a4453b0493670b2f52a65b79fe070c926bc28c8e
1 change: 1 addition & 0 deletions lib/internal/streams/transform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ Transform.prototype._write = function(chunk, encoding, callback) {
wState.ended || // Backwards compat.
length === rState.length || // Backwards compat.
rState.length < rState.highWaterMark ||
rState.highWaterMark === 0 ||
rState.length === 0
) {
callback();
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-stream-passthrough-drain.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';
const common = require('../common');
const { PassThrough } = require('stream');

const pt = new PassThrough({ highWaterMark: 0 });
pt.on('drain', common.mustCall());
pt.write('hello');
pt.read().toString();