Skip to content

doc: add pref to using draft PR versus WIP label #40824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 3 commits into from
Nov 19, 2021
Merged

doc: add pref to using draft PR versus WIP label #40824

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d26eba6
doc: add pref to using draft PR versus WIP label
mhdawson Nov 15, 2021
7fa52ce
Update doc/guides/contributing/pull-requests.md
mhdawson Nov 17, 2021
69b5670
Update doc/guides/contributing/pull-requests.md
mhdawson Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
doc: add pref to using draft PR versus WIP label 
- add to the contribution guide that we prefer that
  people use draft PRs instead of the WIP label.

Signed-off-by: Michael Dawson <[email protected]>
  • Loading branch information
@mhdawson
mhdawson committed Nov 15, 2021
commit d26eba6833f7d83a092f11ddbf07799fc245c913
5 changes: 5 additions & 0 deletions doc/guides/contributing/pull-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,11 @@ details, but feel free to skip parts if you're not sure what to put.

Once opened, pull requests are usually reviewed within a few days.

To get feedback on your proposed change even though it is not ready
to land, use the `Convert to draft` option in the GitHub UI.
This is preferred over the `WIP` label as it will prevent the PR
from being landed before you are ready.

### Step 9: Discuss and update

You will probably get feedback or requests for changes to your pull request.
Expand Down