test: Add auth option case for url.format#40516
Merged
nodejs-github-bot merged 2 commits intonodejs:masterfrom Dec 2, 2021
Merged
test: Add auth option case for url.format#40516nodejs-github-bot merged 2 commits intonodejs:masterfrom
auth option case for url.format#40516nodejs-github-bot merged 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
needs-ci
wafuwafu13
force-pushed
the
urlformat-auth
branch
from
f6fd9a8 to
61eae92
Compare
jasnell
approved these changes
Oct 24, 2021
VoltrexKeyva
approved these changes
Oct 25, 2021
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 26, 2021
This comment has been minimized.
This comment has been minimized.
Ayase-252
added
the
author ready
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
33 tasks
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This was referenced Oct 30, 2021
This comment has been minimized.
This comment has been minimized.
This was referenced Nov 3, 2021
45 tasks
aduh95
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
Collaborator
This was referenced Nov 26, 2021
Collaborator
Collaborator
Collaborator
Collaborator
Ayase-252
added
the
commit-queue
Ayase-252
approved these changes
Dec 2, 2021
Member
Ayase-252
left a comment
Ayase-252
left a comment
There was a problem hiding this comment.
Finally, we made CI green. Thanks for contribution!
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 9e0fb1a |
This was referenced Dec 3, 2021
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
PR-URL: #40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
PR-URL: #40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
PR-URL: #40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
PR-URL: #40516 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Qingyu Deng <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/dist/latest-v17.x/docs/api/url.html#urlurltohttpoptionsurl