tools: update ESLint to 8.0.0 by Trott · Pull Request #40394 · nodejs/node

Trott · 2021-10-10T01:12:55Z

No description provided.

aduh95

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

Trott · 2021-10-10T14:21:08Z

nit: 0463afb and ada8b26 could be squashed together as it's related to the npm upgrade and should probably have landed as part of #40369 IIUC.

I agree. Squashed.

lpinca

RSLGTM

Changes to the npm dependency in the core repo require changes to update-eslint.sh and update-bable-eslint.sh. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

ESLint 8.0.0 introduced support for top level await, so @babel/plugin-syntax-top-level-await is no longer necessary. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

ESLint 8.0.0 makes the plugin unnecessary. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

As of ESLint 8.0.0 at least, this plugin is unnecessary. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Remove unused plugins and update @babel/eslint-parser PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Trott · 2021-10-12T01:38:34Z

Landed in 40db88b...012152d

Changes to the npm dependency in the core repo require changes to update-eslint.sh and update-bable-eslint.sh. PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

ESLint 8.0.0 introduced support for top level await, so @babel/plugin-syntax-top-level-await is no longer necessary. PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

ESLint 8.0.0 makes the plugin unnecessary. PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

As of ESLint 8.0.0 at least, this plugin is unnecessary. PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Remove unused plugins and update @babel/eslint-parser PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 10, 2021

Trott force-pushed the eslint-update-8.0.0 branch 4 times, most recently from ee9dfb1 to 32b353d Compare October 10, 2021 01:44

Trott mentioned this pull request Oct 10, 2021

tools: update babel-eslint plugins #40395

Closed

targos approved these changes Oct 10, 2021

View reviewed changes

Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 10, 2021

aduh95 approved these changes Oct 10, 2021

View reviewed changes

Trott force-pushed the eslint-update-8.0.0 branch from 38e6e18 to cf7749f Compare October 10, 2021 14:20

lpinca approved these changes Oct 11, 2021

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021

Trott added 7 commits October 11, 2021 18:37

tools: prepare ESLint rules for 8.0.0 requirements

dd8e219

PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

tools: update ESLint to 8.0.0

8ca76eb

PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

tools: remove @bable/plugin-syntax-class-properties

b39db95

ESLint 8.0.0 makes the plugin unnecessary. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

tools: remove @babel/plugin-syntax-import-assertions

43c780e

As of ESLint 8.0.0 at least, this plugin is unnecessary. PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

tools: udpate @babel/eslint-parser

012152d

Remove unused plugins and update @babel/eslint-parser PR-URL: nodejs#40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Trott force-pushed the eslint-update-8.0.0 branch from cf7749f to 012152d Compare October 12, 2021 01:38

Trott merged commit 012152d into nodejs:master Oct 12, 2021

Trott deleted the eslint-update-8.0.0 branch October 12, 2021 01:40

Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2021

targos pushed a commit that referenced this pull request Oct 13, 2021

tools: prepare ESLint rules for 8.0.0 requirements

43b97c7

PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

targos pushed a commit that referenced this pull request Oct 13, 2021

tools: update ESLint to 8.0.0

d9157aa

PR-URL: #40394 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

BethGriggs mentioned this pull request Oct 14, 2021

2021-10-19, Version 17.0.0 (Current) #40119

Merged

2 tasks

aduh95 mentioned this pull request Oct 14, 2021

tools: add support for import assertions in linter #39924

Closed

richardlau mentioned this pull request Oct 18, 2021

v16.12.0 proposal #40504

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tools: update ESLint to 8.0.0#40394

tools: update ESLint to 8.0.0#40394
Trott merged 7 commits intonodejs:masterfrom
Trott:eslint-update-8.0.0

Trott commented Oct 10, 2021

Uh oh!

aduh95 left a comment •

edited

Loading

Uh oh!

Trott commented Oct 10, 2021 •

edited

Loading

Uh oh!

lpinca left a comment

Uh oh!

Trott commented Oct 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Trott commented Oct 10, 2021

Uh oh!

aduh95 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lpinca left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Oct 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aduh95 left a comment •

edited

Loading

Trott commented Oct 10, 2021 •

edited

Loading