Skip to content

deps: fix building with system c-ares on Linux #39739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
felixonmars wants to merge 2 commits into from
Closed

deps: fix building with system c-ares on Linux #39739

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aff98a5
deps: fix building with system c-ares on Linux
felixonmars Aug 11, 2021
db46439
build: ignore cpplint for third-party ares_nameser.h
felixonmars Aug 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
deps: fix building with system c-ares on Linux 
The change in #39724 breaks building with system c-ares
(`--shared-cares`):
```
In file included from ../src/cares_wrap.cc:25:
../src/cares_wrap.h:25:11: fatal error: ares_nameser.h: No such file or
directory
   25 | # include <ares_nameser.h>
      |           ^~~~~~~~~~~~~~~~
```

Since `ares_nameser.h` isn't available with a default system c-ares
installation, let's copy it as our private header here.

Tested to build fine on Arch Linux with shared c-ares.
  • Loading branch information
@felixonmars
felixonmars committed Aug 12, 2021
commit aff98a5667c22794e2eaf658f6dfbee54cdd4a3b
Loading