Skip to content

[v14.x] deps: upgrade npm to 6.14.14#39553

Closed
darcyclarke wants to merge 1 commit intonodejs:v14.x-stagingfrom
npm:npm-6.14.14
Closed

[v14.x] deps: upgrade npm to 6.14.14#39553
darcyclarke wants to merge 1 commit intonodejs:v14.x-stagingfrom
npm:npm-6.14.14

Conversation

@darcyclarke
Copy link
Member

@darcyclarke darcyclarke commented Jul 27, 2021

6.14.14 (2021-07-27)

DEPENDENCIES

@github-actions github-actions bot added dont-land-on-v12.x fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Jul 27, 2021
@darcyclarke darcyclarke mentioned this pull request Jul 27, 2021
Closed
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 27, 2021

CI: https://ci.nodejs.org/job/node-test-pull-request/39301/

@richardlau
Copy link
Member

richardlau commented Jul 27, 2021

@nodejs/actions Anyone know why the labelling workflow added dont-land-on-v14.x/dont-land-on-v12.x labels to this PR? Is the workflow picking up the label config from master rather than v14.x-staging?

@targos
Copy link
Member

targos commented Jul 28, 2021

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

@richardlau
Copy link
Member

richardlau commented Jul 28, 2021

Is the workflow picking up the label config from master rather than v14.x-staging?

Yes, and it's intended: https://github.com/nodejs/node-pr-labeler/blob/d4cf1b8b9f23189c37917000e5e17e796c770a6b/index.js#L47

Thanks. It'll apply the wrong labels to npm PRs to LTS, but maybe that's infrequent enough that we just live with it and manually adjust?

@aduh95 aduh95 changed the title deps: upgrade npm to 6.14.14 [v14.x] deps: upgrade npm to 6.14.14 Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@darcyclarke @richardlau
deps: upgrade npm to 6.14.14
7557130 
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@richardlau
Copy link
Member

richardlau commented Jul 28, 2021

Landed in 7557130

@richardlau richardlau closed this Jul 28, 2021
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@darcyclarke @richardlau
deps: upgrade npm to 6.14.14
ccba211 
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@darcyclarke @richardlau
deps: upgrade npm to 6.14.14
ddc8dde 
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
richardlau pushed a commit that referenced this pull request Jul 28, 2021
@darcyclarke @richardlau
deps: upgrade npm to 6.14.14
acf5279 
PR-URL: #39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
This was referenced Jul 28, 2021
Merged
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@darcyclarke @foxxyz
deps: upgrade npm to 6.14.14
449afd7 
PR-URL: nodejs#39553
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
@wraithgar wraithgar deleted the npm-6.14.14 branch June 26, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@darcyclarke @nodejs-github-bot @richardlau @targos @BethGriggs