Skip to content

src: use global SealHandleScope #3945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevnorris wants to merge 6 commits into from
Closed

src: use global SealHandleScope #3945

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8344161
build: fix --without-ssl compile time error
bnoordhuis Nov 14, 2015
ca97fb6
deps: upgrade npm to 2.14.9
othiym23 Nov 6, 2015
caa16b4
tls: prevent server from using dhe keys < 768
mhdawson Nov 17, 2015
3aa093e
deps: backport 1f8555 from v8's upstream
trevnorris Sep 23, 2015
c44a95d
src: use global SealHandleScope
trevnorris Sep 23, 2015
7d72435
node: fix leaking Context handle
trevnorris Nov 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: use global SealHandleScope 
Helps to find Handle leaks in Debug mode.

Ref: a5244d3 "deps: backport 1f8555 from v8's upstream"
  • Loading branch information
@trevnorris
trevnorris committed Nov 24, 2015
commit c44a95dcec35b36065940c002b9dbb13efe55a39
31 changes: 18 additions & 13 deletions src/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ using v8::Number;
using v8::Object;
using v8::ObjectTemplate;
using v8::PropertyCallbackInfo;
using v8::SealHandleScope;
using v8::String;
using v8::TryCatch;
using v8::Uint32;
Expand Down Expand Up @@ -3755,19 +3756,23 @@ int Start(int argc, char** argv) {
if (use_debug_agent)
EnableDebug(env);

bool more;
do {
more = uv_run(env->event_loop(), UV_RUN_ONCE);
if (more == false) {
EmitBeforeExit(env);

// Emit `beforeExit` if the loop became alive either after emitting
// event, or after running some callbacks.
more = uv_loop_alive(env->event_loop());
if (uv_run(env->event_loop(), UV_RUN_NOWAIT) != 0)
more = true;
}
} while (more == true);
{
SealHandleScope seal(node_isolate);
bool more;
do {
more = uv_run(env->event_loop(), UV_RUN_ONCE);
if (more == false) {
EmitBeforeExit(env);

// Emit `beforeExit` if the loop became alive either after emitting
// event, or after running some callbacks.
more = uv_loop_alive(env->event_loop());
if (uv_run(env->event_loop(), UV_RUN_NOWAIT) != 0)
more = true;
}
} while (more == true);
}

code = EmitExit(env);
RunAtExit(env);

Expand Down