Skip to content

tty: enable buffering #39253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 5 commits into from
Closed

tty: enable buffering #39253

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1dd2f48
tty: enable buffering
ronag Jul 3, 2021
48500b4
fixup
ronag Jul 3, 2021
6731cde
fixup
ronag Jul 3, 2021
4e96f9f
Update lib/internal/bootstrap/switches/is_main_thread.js
ronag Jul 5, 2021
8283670
fixup: readableHighWaterMark
ronag Jul 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tty: enable buffering 
HWM was set to 0 which would cause e.g. stdout.write(...) to
always return false.

Refs: #39246
  • Loading branch information
@ronag
ronag committed Jul 3, 2021
commit 1dd2f48b7b7b2c36655019fb20d27bdc4167a151
8 changes: 7 additions & 1 deletion deps/npm/node_modules/gauge/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion lib/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ function WriteStream(fd) {
}

net.Socket.call(this, {
highWaterMark: 0,
handle: tty,
manualStart: true
});
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-stdout-stderr-write.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
'use strict';

require('../common');
const assert = require('assert');

// https://github.com/nodejs/node/pull/39246
assert.strictEqual(process.stderr.write('asd'), true);
assert.strictEqual(process.stdout.write('asd'), true);