Skip to content

doc: fix napi_default_property name #39104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Theldus wants to merge 1 commit into from
Closed

doc: fix napi_default_property name #39104

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
doc: fix napi_default_property name 
Fix the napi_default_jsproperty flag of the napi_property_attributes
enum that was incorrectly referred to as napi_default_property.

Signed-off-by: Davidson Francis <[email protected]>
  • Loading branch information
@Theldus
Theldus committed Jun 21, 2021
commit 2cc5b73ceb05f6b20ffba050daddace9e5683ea3
6 changes: 3 additions & 3 deletions doc/api/n-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3798,7 +3798,7 @@ typedef enum {
napi_default_method = napi_writable | napi_configurable,

// Default for object properties, like in JS obj[prop].
napi_default_property = napi_writable |
napi_default_jsproperty = napi_writable |
napi_enumerable |
napi_configurable,
} napi_property_attributes;
Expand All @@ -3821,8 +3821,8 @@ They can be one or more of the following bitflags:
[`napi_define_class`][]. It is ignored by `napi_define_properties`.
* `napi_default_method`: Like a method in a JS class, the property is
configurable and writeable, but not enumerable.
* `napi_default_property`: Like a property set via assignment in JavaScript, the
property is writable, enumerable, and configurable.
* `napi_default_jsproperty`: Like a property set via assignment in JavaScript,
the property is writable, enumerable, and configurable.

#### napi_property_descriptor

Expand Down