Skip to content

[v14.x] deps: V8: cherry-pick b0a7f5691113 #39051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 4 commits into from
Closed

[v14.x] deps: V8: cherry-pick b0a7f5691113 #39051

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cea8e4f
deps: V8: cherry-pick b0a7f5691113
targos Jun 16, 2021
ea1f70e
test: add NumberFormat resolvedOptions test
richardlau Jul 15, 2021
b1055fb
deps: V8: backport 16ffec97e5eb
targos Jul 20, 2021
08a3272
deps: V8: backport ae7bfb3f03b3
targos Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: backport 16ffec97e5eb 
Original commit message:

    Fix maximize/minimize of Intl.Locale

    Roll ICU to 46f53dfc
    chromium/src/DEPS already roll in https://chromium-review.googlesource.com/c/chromium/src/+/2235734

    Bug: v8:10448
    Change-Id: I147189527e57282c6cc7a1e92f832275d5ef55c6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2237353
    Reviewed-by: Shu-yu Guo <[email protected]>
    Commit-Queue: Frank Tang <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#68275}

Refs: v8/v8@16ffec9
  • Loading branch information
@targos
targos committed Jul 20, 2021
commit b1055fbf7500a2be9d7a2586f3a09addb914ba21
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.74',
'v8_embedder_string': '-node.75',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/test/intl/regress-7982.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ assertEquals("zh-TW-u-ca-chinese", new Intl.Locale("zh-TW-u-ca-chinese").minimiz
assertEquals("zh-Hant-HK-u-ca-chinese", new Intl.Locale("zh-HK-u-ca-chinese").maximize().toString());
assertEquals("zh-HK-u-ca-chinese", new Intl.Locale("zh-HK-u-ca-chinese").minimize().toString());
assertEquals("zh-Hant-TW-u-ca-chinese", new Intl.Locale("zh-Hant-u-ca-chinese").maximize().toString());
assertEquals("zh-Hant-u-ca-chinese", new Intl.Locale("zh-Hant-u-ca-chinese").minimize().toString());
assertEquals("zh-TW-u-ca-chinese", new Intl.Locale("zh-Hant-u-ca-chinese").minimize().toString());
assertEquals("zh-Hans-CN-u-ca-chinese", new Intl.Locale("zh-Hans-u-ca-chinese").maximize().toString());
assertEquals("zh-u-ca-chinese", new Intl.Locale("zh-Hans-u-ca-chinese").minimize().toString());
assertEquals("zh-Hant-CN-u-ca-chinese", new Intl.Locale("zh-Hant-CN-u-ca-chinese").maximize().toString());
Expand Down
3 changes: 0 additions & 3 deletions deps/v8/test/test262/test262.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,9 +507,6 @@
'intl402/Intl/getCanonicalLocales/unicode-ext-canonicalize-yes-to-true': [FAIL],
'intl402/Intl/getCanonicalLocales/unicode-ext-key-with-digit': [FAIL],

# http://crbug/v8/10448
'intl402/Locale/prototype/minimize/removing-likely-subtags-first-adds-likely-subtags': [FAIL],

# https://bugs.chromium.org/p/v8/issues/detail?id=9646
'built-ins/ThrowTypeError/name': [FAIL],
'language/expressions/class/name': [FAIL],
Expand Down