doc: clarify child_process close event#38181
Closed
Linkgoron wants to merge 2 commits intonodejs:masterfrom
Closed
doc: clarify child_process close event#38181Linkgoron wants to merge 2 commits intonodejs:masterfrom
Linkgoron wants to merge 2 commits intonodejs:masterfrom
Conversation
clarify the 'close' event description in the child_process docs. fixes: nodejs#37998
nodejs-github-bot
added
child_process
lpinca
approved these changes
Apr 10, 2021
Linkgoron
added
the
author ready
marsonya
approved these changes
Apr 11, 2021
jasnell
approved these changes
Apr 12, 2021
Member
|
Landed in 474fbb5 |
jasnell
pushed a commit
that referenced
this pull request
Apr 12, 2021
clarify the 'close' event description in the child_process docs. fixes: #37998 PR-URL: #38181 Fixes: #37998 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 15, 2021
clarify the 'close' event description in the child_process docs. fixes: #37998 PR-URL: #38181 Fixes: #37998 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
clarify the 'close' event description in the child_process docs. fixes: #37998 PR-URL: #38181 Fixes: #37998 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
clarify the 'close' event description in the child_process docs. fixes: #37998 PR-URL: #38181 Fixes: #37998 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify the 'close' event description in the child_process docs.
This event is a bit confusing, as the documentation did not state that:
child_processhas failed to spawn (and thus,exitwill never be emitted). Another detail, that I did not add to the docs, is that in this case the exit code passed to the closed handler is negative. Should this be mentioned?fixes: #37998