http: correctly optimize debug function#37966
Conversation
Exporting a variable that will be mutated later doesn't work. Refs: nodejs#37937
|
@mcollina can you verify the fix on your benchmarking server? |
|
Yes it does but not completely. There are probably a few others but this does improve things if landed on top of #37963 (nothing otherwise as the other commit is a dominant bottleneck). |
Is still slightly faster than this fix alone (72k vs 70k). Can we add this as well? |
I can add it, but I honestly don't see how the difference can be measured, as this code path is hit only eight times during the entire process life, regardless of the number of HTTP requests. |
I'll check it further and verify again. |
|
This is ok to land, there are no other regression (I checked extensively) |
Exporting a variable that will be mutated later doesn't work. Refs: #37937 PR-URL: #37966 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
|
Landed in 3dee233 |
Exporting a variable that will be mutated later doesn't work. Refs: #37937 PR-URL: #37966 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Exporting a variable that will be mutated later doesn't work.
Refs: #37937