worker_threads: fix spawning from preload scripts#37481
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
worker_threads: fix spawning from preload scripts#37481jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
addaleax
reviewed
Feb 23, 2021
addaleax
reviewed
Feb 23, 2021
Member
Author
|
@addaleax ... what would you think of a command line argument that imposed a process-level upper limit on the maximum number of concurrent Workers? |
Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#36531
jasnell
force-pushed
the
fix-preload-workers
branch
from
a2243e1 to
671bbc7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
I guess that would be fine – there’s precedent for that kind of thing in the form of |
Collaborator
addaleax
approved these changes
Feb 27, 2021
jasnell
added a commit
that referenced
this pull request
Mar 1, 2021
Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: #36531 PR-URL: #37481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Member
Author
|
Landed in 360e8c8 |
lpinca
pushed a commit
to lpinca/node
that referenced
this pull request
Mar 2, 2021
Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: nodejs#36531 PR-URL: nodejs#37481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 2, 2021
Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: #36531 PR-URL: #37481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Fix spawning nested worker threads from preload scripts and warn about doing so. Signed-off-by: James M Snell <[email protected]> Fixes: #36531 PR-URL: #37481 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix spawning nested worker threads from preload scripts and
warn about doing so.
Signed-off-by: James M Snell [email protected]
Fixes: #36531