doc: remove generated from dsaEncoding description#37459
Closed
kaznovac wants to merge 2 commits intonodejs:masterfrom
Closed
doc: remove generated from dsaEncoding description#37459kaznovac wants to merge 2 commits intonodejs:masterfrom
kaznovac wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
crypto
Trott
approved these changes
Feb 21, 2021
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM. Can you fix the typographical error (generted->generated) in the commit message?
mscdex
reviewed
Feb 21, 2021
mscdex
reviewed
Feb 21, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action'
kaznovac
changed the title
Contributor
Author
|
@Trott @mscdex thank you both for the review @Trott i've fixed typo in the commit message @mscdex my rationale is that |
marsonya
approved these changes
Feb 21, 2021
Member
|
I probably wrote these descriptions. I agree with @mscdex, but I don't feel strongly about it.
Following this argument, I guess just having documentation breaks DRY. Just look at the code instead, it has all the information 😉 |
Co-authored-by: mscdex <[email protected]>
Contributor
Author
jasnell
approved these changes
Mar 9, 2021
jasnell
pushed a commit
that referenced
this pull request
Mar 9, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in 4947ce5 |
danielleadams
pushed a commit
that referenced
this pull request
Mar 16, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
May 27, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
remove term `generated` from `dsaEncoding` parameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action' PR-URL: #37459 Fixes: #37454 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Apr 18, 2023
This was referenced Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove term
generatedfromdsaEncodingparameter's description - the parameter is used to specify the format of the signature, function dictates the signature 'action'Fixes: #37454