src: fix warning in string_search.h#37146
Conversation
nodejs-github-bot
added
buffer
|
The change looks OK, but I opened the issue because I'm not sure it's enough to just fix the warning. |
|
@targos I realise that the code here matches this: |
|
We cannot use that code from V8 as it is not part of their public API. |
|
In that case should we prefer using the types that were used originally? |
V8 implements this for strings. Strings in JS have a bounded size, which is smaller than |
RaisinTen
added
the
author ready
|
Landed in c148c3a |
Fixes: #37145 PR-URL: #37146 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #37145 PR-URL: #37146 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Fixes: #37145 PR-URL: #37146 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
8 participants
Fixes: #37145