Closed
Conversation
nodejs-github-bot
added
dont-land-on-v12.x
quic
cjihrig
approved these changes
Jan 21, 2021
RaisinTen
approved these changes
Jan 21, 2021
RaisinTen
added
the
author ready
aduh95
approved these changes
Jan 21, 2021
Contributor
|
@RaisinTen don't forget to spawn a CI job before marking PR as |
Collaborator
Member
|
@aduh95 Thanks for telling. I will do it next time for sure. :) |
juanarbol
approved these changes
Jan 21, 2021
jasnell
approved these changes
Jan 22, 2021
lpinca
approved these changes
Jan 22, 2021
Collaborator
Trott
approved these changes
Jan 23, 2021
Member
|
Landed in 0e7e91f |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Jan 23, 2021
PR-URL: nodejs#37017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
targos
pushed a commit
that referenced
this pull request
Feb 2, 2021
PR-URL: #37017 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rich Trott <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.